Add rainbird rain delay number entity, deprecating the sensor and service#86208
Merged
Conversation
Contributor
|
Hey there @konikvranik, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
19 tasks
MartinHjelmare
approved these changes
Jan 20, 2023
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
frenck
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The Rain Bird integration has changed the way the "Rain Delay" is managed. The Rain Delay, which pauses irrigation for a specified number of days, is now manage with a Number entity which can be controlled directly from the UI. The existing service call is
rainbird.set_rain_delayand the Raindelay sensor have been deprecated. Any existing automations or scripts that make service calls torainbird.set_rain_delaywill need to be replaced with a call tonumber.set_value. Additionally, the existing service call was updated to require a config entry parameter since it previously had undefined behavior, so it is recommend to move directly to the new number service call.Proposed change
Add the rain delay number entity, deprecating the sensor and service, as discussed in #85271
This adds the Number entity, and creates an issue in the issue registry to remind users to switch services. The tests were borrowed from existing functionality of the sensor and service.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: